Skip to content

Add caveat for allowed_mentions in interactions #7629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 26, 2025

Conversation

AlmostSuspense
Copy link
Contributor

Adds documentation for this change from 2021 which somehow never made it to the docs

@AlmostSuspense AlmostSuspense requested a review from a team as a code owner June 22, 2025 13:25
@AlmostSuspense AlmostSuspense requested review from markmandel and removed request for a team June 22, 2025 13:25
Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll take it for a spin tomorrow just to preview the changes, but assuming no issue there, this is good to merge.

Thanks for the expanded update!

"allowed_mentions": {
"users": ["123", "125"]
"users": ["123", "456"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this change to the numbers not being so close 👍🏻

@markmandel
Copy link
Contributor

oh no, markdown formatting issue! 😱

1 files contain markdown tables to format:
- docs/resources/message.mdx

If you run npm run fix:tables in the project root, it should format all your tables appropriately, and we should be good to go.

@AlmostSuspense
Copy link
Contributor Author

a single space on each line caused this haha, should be fixed now though!

Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super small nit, but just wanted to drop these bullet points, since previewing it, it looks like this:
image

which looks a bit weird.

(Unfortunately you can't see this automatically - hoping to fix this in the future!)

Here's a screenshot of how your content renders in full:
image

@AlmostSuspense
Copy link
Contributor Author

are codeblocks supposed to render with two tones of black?

@markmandel
Copy link
Contributor

are codeblocks supposed to render with two tones of black?

Yeah, they've been doing that lately. Something got updated - at some point we'll go find out what it was.

Copy link
Contributor

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@markmandel markmandel merged commit 16e0558 into discord:main Jun 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants